Skip to content

Commit

Permalink
[Stable/Efs-Provisioner] add namespace to deployment/sa (helm#23056)
Browse files Browse the repository at this point in the history
* feat: [Stable/Efs-Provisioner] add namespace to deployment/sa

Add the namespace information to deployment and serviaccount. this
Prevent helm3 to push the object to the current ns and not the one
Refered by the option "--namespace"

Signed-off-by: David Sabatie <[email protected]>

* bump chart version

Signed-off-by: David Sabatie <[email protected]>

* fix bad char in serviceaccount file

Signed-off-by: David Sabatie <[email protected]>

* fix bad char in deployment

Signed-off-by: David Sabatie <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
  • Loading branch information
golgoth31 authored and Miguel Mingorance committed Aug 28, 2020
1 parent 3b3e2d8 commit c4a930e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/efs-provisioner/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: efs-provisioner
description: A Helm chart for the AWS EFS external storage provisioner
version: 0.12.0
version: 0.12.1
appVersion: v2.4.0
home: https://github.com/kubernetes-incubator/external-storage/tree/master/aws/efs
sources:
Expand Down
1 change: 1 addition & 0 deletions stable/efs-provisioner/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ kind: Deployment
apiVersion: apps/v1
metadata:
name: {{ template "efs-provisioner.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
app: {{ template "efs-provisioner.name" . }}
env: {{ .Values.global.deployEnv }}
Expand Down
1 change: 1 addition & 0 deletions stable/efs-provisioner/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "efs-provisioner.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
labels:
app: {{ template "efs-provisioner.name" . }}
env: {{ .Values.global.deployEnv }}
Expand Down

0 comments on commit c4a930e

Please sign in to comment.