Skip to content

Commit

Permalink
[stable/mongodb-replicaset] Warning fixed, made client service option…
Browse files Browse the repository at this point in the history
…al (helm#22209, helm#22759). (helm#22971)

Made the headless client service optional, fixed warning when used as a subchart.

Signed-off-by: Berk Soysal <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
  • Loading branch information
herrberk authored and Miguel Mingorance committed Aug 28, 2020
1 parent c659a19 commit 92e5a3f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion stable/mongodb-replicaset/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: mongodb-replicaset
home: https://github.com/mongodb/mongo
version: 3.16.1
version: 3.16.2
appVersion: 3.6
description: NoSQL document-oriented database that stores JSON-like documents with
dynamic schemas, simplifying the integration of data in content-driven applications.
Expand Down
1 change: 1 addition & 0 deletions stable/mongodb-replicaset/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ The following table lists the configurable parameters of the mongodb chart and t
| `extraVars` | Set environment variables for the main container | `{}` |
| `extraLabels` | Additional labels to add to resources | `{}` |
| `extraVolumes` | Additional volumes to add to the resources | `[]` |
| `clientService.enabled` | Enables the headless client service | `true` |
| `global.namespaceOverride` | Override the deployment namespace | Not set (`Release.Namespace`) |

*MongoDB config file*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# A headless service for client applications to use
{{- if .Values.clientService.enabled -}}
# An optional headless service for client applications to use
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -30,4 +31,4 @@ spec:
selector:
app: {{ template "mongodb-replicaset.name" . }}
release: {{ .Release.Name }}

{{- end -}}
9 changes: 7 additions & 2 deletions stable/mongodb-replicaset/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ nameOverride: ""
fullnameOverride: ""

# Override the deployment namespace
global:
# namespaceOverride: ""
global: {}
# global:
# namespaceOverride: ""

replicas: 3
port: 27017
Expand Down Expand Up @@ -198,3 +199,7 @@ livenessProbe:
failureThreshold: 3
periodSeconds: 10
successThreshold: 1

# Enables/disables the headless client service
clientService:
enabled: true

0 comments on commit 92e5a3f

Please sign in to comment.