Update to work with puppet-lint >= 2.4 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppet-lint 2.4 introduced what was supposed to be a non-breaking change that fixed how interpolated expressions were tokenised, but this unfortunately broke the check in this plugin (I'm going to have to rethink how plugins factor into my change classifications for semver purposes). Anyway, this PR should fix up the issues with this plugin and puppet-lint 2.4.x by extending the existing logic to handle cases where variables like `$facts['osfamily']` are represented internally as a sequence of tokens rather than a single token.
|
Thanks for submitting the PR to fix this. |
alexjfisher
added a commit
to alexjfisher/puppet-lint-top_scope_facts-check
that referenced
this pull request
Jul 19, 2022
Puppet-lint 2.4 contained a breaking change in rodjek/puppet-lint#846 Fixups have already been applied in other plugins such as mmckinst/puppet-lint-legacy_facts-check#32 This commit reverts ee3a6b0 updates the minimum puppet-lint version to 2.4, and fixes up a couple of tests where the location of the warnings have changed by one character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppet-lint 2.4 introduced what was supposed to be a non-breaking change
that fixed how interpolated expressions were tokenised, but this
unfortunately broke the check in this plugin (I'm going to have to
rethink how plugins factor into my change classifications for semver
purposes).
Anyway, this PR should fix up the issues with this plugin and
puppet-lint 2.4.x by extending the existing logic to handle cases where
variables like
$facts['osfamily']are represented internally asa sequence of tokens rather than a single token.