Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adoption in to default puppet-lint plugins #41

Open
chelnak opened this issue Feb 23, 2023 · 2 comments
Open

Adoption in to default puppet-lint plugins #41

chelnak opened this issue Feb 23, 2023 · 2 comments

Comments

@chelnak
Copy link

chelnak commented Feb 23, 2023

Hey @mmckinst, hope you are doing well!

We recently asked, if it would be OK to adopt your top_scope_facts_check in to puppet-lint as a default plugin.

Would you be happy for us to adopt this one too? I'd ensure that credit was given in the migrated code!

Additionally, the license would change to MIT given that is what puppet-lint currently uses.

Thank you!

bastelfreak added a commit to bastelfreak/voxpupuli-puppet-lint-plugins that referenced this issue Feb 24, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3:
puppetlabs/puppet-lint#85
We need to wait with merging this until puppet-lint 3.1 is released.
This also depends on mmckinst/puppet-lint-legacy_facts-check#41
@mmckinst
Copy link
Owner

I'm also happy to contribute this one to puppet-lint.

@chelnak
Copy link
Author

chelnak commented Feb 27, 2023

Thank you @mmckinst 🙏

bastelfreak added a commit to bastelfreak/voxpupuli-puppet-lint-plugins that referenced this issue Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3:
puppetlabs/puppet-lint#85
We need to wait with merging this until puppet-lint 3.1 is released.
This also depends on mmckinst/puppet-lint-legacy_facts-check#41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants