-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adoption in to default puppet-lint plugins #41
Comments
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this issue
Feb 24, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3: puppetlabs/puppet-lint#85 We need to wait with merging this until puppet-lint 3.1 is released. This also depends on mmckinst/puppet-lint-legacy_facts-check#41
I'm also happy to contribute this one to puppet-lint. |
Thank you @mmckinst 🙏 |
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this issue
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3: puppetlabs/puppet-lint#85 We need to wait with merging this until puppet-lint 3.1 is released. This also depends on mmckinst/puppet-lint-legacy_facts-check#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @mmckinst, hope you are doing well!
We recently asked, if it would be OK to adopt your top_scope_facts_check in to puppet-lint as a default plugin.
Would you be happy for us to adopt this one too? I'd ensure that credit was given in the migrated code!
Additionally, the license would change to MIT given that is what puppet-lint currently uses.
Thank you!
The text was updated successfully, but these errors were encountered: