fix: Fix hiding header on IOS not working #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Phillip-Cognativ thank you! available in v8.0.6! |
mmazzarolo
added a commit
that referenced
this pull request
Jan 16, 2020
* feat: Moved to @react-native-community pickers BREAKING CHANGE * Bump version BREAKING CHANGE: bumping to 8.0.0 * docs: Added v8 info * docs: Update README.md * docs: Update README.md * docs: Update README.md * Update README.md * docs: Update README.md * fix: Fixed modal styling (#306) * fix: Updated TypeScript definitions for v8.0.0 (#307) * Updated dependencies * Fix: Wrong version bump * v8.0.1 * fix: Use getDate() instead of getDay() * v8.0.2 * Type custom components in props as React.ComponentType / PropTypes.elementType (#314) * v8.0.3 * fix: Rename onModalHide to onHide Modal prop to make onHide callback work on iOS (#316) * Export TS interface * v8.0.4 * Mentioned Expo instructions in the README.md * feat: Added custom component types (#336) * v8.0.5 * fix: Fix hiding header on IOS not working (#339) * v8.0.6 * Set the library version to 8.x.x for Expo setup (#342) It would probably makes things easier for people migrating from version 7. Co-authored-by: Michiel De Mey <[email protected]> Co-authored-by: Christiaan van Bemmel <[email protected]> Co-authored-by: Alexey Bulavka <[email protected]> Co-authored-by: Simonas Gildutis <[email protected]> Co-authored-by: Phillip-Cognativ <[email protected]> Co-authored-by: Victor Goya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small fix for broken prop: #301 (comment)
Test Plan