Use StringComparer.OrdinalIgnoreCase instead of string.ToUpperInvaria…

…nt() for case-insensitive differ.
mmanela · Jan 4, 2023 · d30d3bd · d30d3bd
1 parent f53963b
commit d30d3bd
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/DiffPlex/Differ.cs b/DiffPlex/Differ.cs
@@ -61,14 +61,14 @@ public DiffResult CreateDiffs(string oldText, string newText, bool ignoreWhiteSp
             if (newText == null) throw new ArgumentNullException(nameof(newText));
             if (chunker == null) throw new ArgumentNullException(nameof(chunker));
 
-            var pieceHash = new Dictionary<string, int>();
+            var pieceHash = new Dictionary<string, int>(ignoreCase ? StringComparer.OrdinalIgnoreCase : StringComparer.Ordinal);
             var lineDiffs = new List<DiffBlock>();
 
             var modOld = new ModificationData(oldText);
             var modNew = new ModificationData(newText);
 
-            BuildPieceHashes(pieceHash, modOld, ignoreWhiteSpace, ignoreCase, chunker);
-            BuildPieceHashes(pieceHash, modNew, ignoreWhiteSpace, ignoreCase, chunker);
+            BuildPieceHashes(pieceHash, modOld, ignoreWhiteSpace, chunker);
+            BuildPieceHashes(pieceHash, modNew, ignoreWhiteSpace, chunker);
 
             BuildModificationData(modOld, modNew);
 
@@ -326,7 +326,7 @@ private static void BuildModificationData
             }
         }
 
-        private static void BuildPieceHashes(IDictionary<string, int> pieceHash, ModificationData data, bool ignoreWhitespace, bool ignoreCase, IChunker chunker)
+        private static void BuildPieceHashes(IDictionary<string, int> pieceHash, ModificationData data, bool ignoreWhitespace, IChunker chunker)
         {
             var pieces = string.IsNullOrEmpty(data.RawData)
                 ? emptyStringArray
@@ -340,7 +340,6 @@ private static void BuildPieceHashes(IDictionary<string, int> pieceHash, Modific
             {
                 string piece = pieces[i];
                 if (ignoreWhitespace) piece = piece.Trim();
-                if (ignoreCase) piece = piece.ToUpperInvariant();
 
                 if (pieceHash.ContainsKey(piece))
                 {