Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test headless #9

Closed
mmacfadden opened this issue May 15, 2021 · 1 comment
Closed

Make test headless #9

mmacfadden opened this issue May 15, 2021 · 1 comment
Assignees
@mmacfadden
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@mmacfadden
Copy link
Owner

The current test require you to open them in a browser. We should us jsdom to make them headless.
@mmacfadden mmacfadden added the enhancement New feature or request label May 15, 2021
@mmacfadden mmacfadden added this to the 1.0.0 milestone May 15, 2021
@mmacfadden mmacfadden self-assigned this May 15, 2021
@mmacfadden mmacfadden changed the title Convert test to headless. Make test headless May 15, 2021
@mmacfadden
Copy link
Owner Author

jsdom doesn't work that well for mutation observers. It was leading to many errors. Thus, I decided to use Karma instead.

mmacfadden added a commit that referenced this issue May 15, 2021
@mmacfadden
Updated the tests to use Karma for headless testing.
9e55fb2 
Fixes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmacfadden mmacfadden

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@mmacfadden