Reduce compile time contribution of next_key_seed and next_value_seed
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-nie
commented
Aug 6, 2024
Comment on lines
+549
to
+553
| match self.next_key_deserializer() { | ||
| Ok(Some(key_de)) => seed.deserialize(key_de).map(Some), | ||
| Ok(None) => Ok(None), | ||
| Err(error) => Err(error), | ||
| } |
There was a problem hiding this comment.
If you prefer I can make this more idiomatic, but in functions that get instantiated a lot, I prefer to keep it simple to keep the generated lines minimal.
|
Thanks! |
s-nie
added a commit
to s-nie/mlua
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
next_key_seedandnext_value_seedproduce many LLVM IR lines, slowing down the compilation. They only need to generate a fraction of the lines as they can share most of the code.deserialize_mapandserde_userdataare also candidates for optimization, but this PR does not touch them.