Add support for XML clips in chains. #1602
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows speed effects to XML clips.
It also adds a properties panel for XML clips.
Also fixes this issue:
https://forum.shotcut.org/t/issues-when-using-mlt-as-a-clip-in-a-timeline/44164
If the XML clip has a filter on the output, the filter will not appear in the project - it is "hidden" inside the chain.
Depends on
mltframework/mlt#1047
This is what the properties panel looks like (similar to the Output properties):
The way this is designed, the embedded XML will always be rendered at the XML clip profile (by the consumer producer). Then it will be converted to the project profile if necessary.
Discussion: Should we show a warning in the properties panel if the XML clip profile does not match the project profile?
Discussion: Do we want to add a button or method to lauch Shotcut from the properties panel so the clip can be edited in another instance of Shotcut? Maybe that would be confusing to have two instances at the same time.