Aead key compromise cleanup #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secret compromise. I mostly moved stuff around and deleted redundant text, but hopefully it will be clearer.
|
This builds on PR#229, so that should be reviewed first. |
rohan-wire
suggested changes
Nov 10, 2023
There was a problem hiding this comment.
Let's finish PR #229 first, then merge that update into this one. I don't think it is possible to review this PR yet because of the overlapping changes with the other PR.
draft-ietf-mls-architecture.md
Outdated
Comment on lines
1409
to
1431
| MLS provides strong authentication within a group, such that a group member | ||
| cannot send a message that appears to be from another group member. | ||
| Additionally, some services require that a recipient be able to prove to the | ||
| service provider that a message was sent by a given client, in order to report | ||
| abuse. MLS supports both of these use cases. In some deployments, these services | ||
| are provided by mechanisms which allow the receiver to prove a message's origin | ||
| to a third party. This is often called "non-repudiation". | ||
|
|
||
| Roughly speaking, "deniability" is the opposite of "non-repudiation", i.e., the | ||
| property that it is impossible to prove to a third party that a message was sent | ||
| by a given sender. MLS does not make any claims with regard to deniability. It | ||
| may be possible to operate MLS in ways that provide certain deniability | ||
| properties, but defining the specific requirements and resulting notions of | ||
| deniability requires further analysis. | ||
|
|
||
| ### Associating a User's Clients | ||
|
|
||
| When the same user uses multiple clients, it may be possible for other members | ||
| of a group to recognize all of those clients as belonging to the same user. For |
There was a problem hiding this comment.
This looks like a mistake. was the intention to delete the entire Non-repudiation vs Deniability discussion?
And then the "Associating a User's Clients" section heading is removed and the second sentence of that section is now under the previous heading???
There was a problem hiding this comment.
Pilot error. This is fixed in #229, so when that PR is done i will rebase.
Co-authored-by: rohan-wire <[email protected]>
beurdouche
approved these changes
Jan 19, 2024
draft-ietf-mls-architecture.md
Outdated
| @@ -1089,7 +1089,7 @@ interoperate. | |||
| is useful for clients that do not have the ability to send the full public | |||
| state in a Welcome message when inviting auser or for client that need to | |||
| recover from a loss of their state. Such public state can contain privacy | |||
| sensitive information such as group members' credentials and related public | |||
| sensitive information such as group members' credentrials and related public | |||
There was a problem hiding this comment.
Suggested change
| sensitive information such as group members' credentrials and related public | |
| sensitive information such as group members' credentials and related public |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.