Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter values of unsatisfied dependencies #343

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

be-marc
Copy link
Member

@be-marc be-marc commented Mar 17, 2021

  • required and dependency check can be activated in ParamSet$check(check_strict = TRUE). Default is FALSE
  • get_values(remove_dependencies = TRUE) (better name?) removes all parameter values with unsatisfied dependencies. Default is TRUE.
  • We added three new parameter to get_values() in recent months: type = c("with_token", "without_token", "only_token"), check_required = TRUE and remove_dependencies = TRUE. We might want to make check_required and remove_dependencies one parameter. TRUE returns valid parameter values and FALSE the parameter values like they are stored currently. For type, we need all three options in mlr3tuning.

@be-marc be-marc marked this pull request as ready for review March 18, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant