Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub command #37

Open
adityagodbole opened this issue Jan 28, 2015 · 2 comments
Open

pubsub command #37

adityagodbole opened this issue Jan 28, 2015 · 2 comments

Comments

@adityagodbole
Copy link

The client uses the pubsub method to create and return the pubsub client. This masks the redis PUBSUB command.
There are two ways I can think of around this

  1. Change the name of the pubsub method to something like pubsub_client
  2. Pass self to PubsubClient.new in the pubsub method and keep a reference to it in the Pubsubclient object. Forward the call to this Client object in a method called pubsub on the PubsubClient object.
@mloughran
Copy link
Owner

Good point; I don't think the command existed when I introduced this API. It's annoying, but I think the correct solution is to rename the pubsub method to pubsub_client as you suggest.

@adityagodbole
Copy link
Author

That would be a breaking change though, and would have to be announced and versioned accordingly

adityagodbole added a commit to adityagodbole/em-hiredis that referenced this issue Jan 29, 2015
Issue mloughran#37. The new Redis pubsub command was getting masked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants