Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for imagick on PHP 8.3 #811

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add support for imagick on PHP 8.3 #811

merged 1 commit into from
Nov 14, 2024

Conversation

mlocati
Copy link
Owner

@mlocati mlocati commented Oct 9, 2023

No description provided.

@mvorisek
Copy link
Contributor

mvorisek commented Oct 31, 2023

with the latest Imagick/imagick@28f2704 master commit the build passes

@mlocati
Copy link
Owner Author

mlocati commented Oct 31, 2023

Let's wait until they publish a new release

@vuryss
Copy link

vuryss commented Dec 7, 2023

@mlocati I think they did :)

@mlocati
Copy link
Owner Author

mlocati commented Dec 7, 2023

I think they did :)

@vuryss are you sure? Isn't 3.7.0 (dated Jan 2022) the most recent imagick version?

@vuryss
Copy link

vuryss commented Dec 7, 2023

I think they did :)

@vuryss are you sure? Isn't 3.7.0 (dated Jan 2022) the most recent imagick version?

Sorry it was my mistake, I saw the support of Imagick for PHP 8.3 was merged and released in brefphp/extra-php-extensions and I thought it was the extension itself.

@ganti
Copy link

ganti commented Dec 8, 2023

There is an open PR at Imagick/imagick#641

@ganti
Copy link

ganti commented Dec 19, 2023

fyi imagick is not working with php:8.3-fpm-alpine3.19

make: *** [Makefile:196: /tmp/pear/temp/imagick/Imagick_arginfo.h] Error 1
ERROR: `make -j8 INSTALL_ROOT="/tmp/pear/temp/pear-build-defaultuserBOGHED/install-imagick-3.7.0" install' failed

@annuh
Copy link

annuh commented Jan 23, 2024

Fyi, using the (unreleased) master branch worked for me: 🙂

install-php-extensions imagick/imagick@master

@jeff1326
Copy link

So what's the status of this PR ?

@jdreesen
Copy link

Still waiting for imagick to be compatible with PHP 8.3, I guess.

@Orkin
Copy link

Orkin commented May 13, 2024

Hello, it is with the use of imagick/imagick@master on install-php-extensions

@StrangePeanut
Copy link

Considering that the master branch works just fine, it seems that we are now waiting for a proper release by someone with an appropriate user role. IIRC there is just one such person.

@pereorga
Copy link

I find this confusing. This is using official php: images:

  • install-php-extensions imagick/imagick used to work fine on PHP 8.3 a few days ago. Most of the time the extension fails to compile now, but sometimes randomly (rarely), it works.
  • install-php-extensions imagick/imagick seems to work fine on PHP 8.4 beta 3.
  • install-php-extensions imagick/imagick@master works fine on PHP 8.3.
  • install-php-extensions imagick/imagick@master fails to compile on PHP 8.4 beta 3.

@mlocati
Copy link
Owner Author

mlocati commented Aug 24, 2024

@pereorga there's nothing I can do about that: it's everything up to the imagick maintainers

@mvorisek
Copy link
Contributor

* `install-php-extensions imagick/imagick@master` fails to compile on PHP 8.4 beta 3.

Please note there is develop branch. You can also use https://github.com/mvorisek/image-php prebuilt images for Alpine or Debian with Imagick ext. included.

edram added a commit to edram/docker-images that referenced this pull request Oct 30, 2024
@mlocati
Copy link
Owner Author

mlocati commented Nov 14, 2024

After a year we still haven't seen a new release of imagick: I updated this PR with a workaround (a temporary one, I hope).

@mlocati mlocati merged commit b677321 into master Nov 14, 2024
40 checks passed
@mlocati mlocati deleted the imagick-php8.3 branch November 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants