Device Attestation (Modular) #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2021 20:35
helpers Moved CopySpantoMutableSpan into src/lib/support/Span.h as a general use routine. Added ExtractVIDFromX509Cert and ExtractAKIDFromX509Cert Changed attestation data to equate with updated spec. coauthor: restyled io
…p ZAP script
Introduced CertChainRequest, CertChainResponse, AttestationRequest and AttestationResponse commands into operational-credentials-cluster.xml
Added the above commands' callbacks to operational-credentials-server.cpp
Introduced the Attestation Nonce buffer to CHIPDevice Class
Added Certificate Chain Request and Attestation Request Commands to CHIPDeviceController
Added global method to Server.cpp in order to retrieve Server's SecureSessionMgr (needed to retrieve Attestation Challenge)
Added support to DAC/PAI certificates in CHIPDevice
Include files from the DA constructor PR
src/credentials/DeviceAttestationConstructor.cpp
src/credentials/DeviceAttestationConstructor.h
mleisner
force-pushed
the
feature/device_attestation_complete
branch
from
4ac999d to
d5e476f
Compare
added 5 commits
September 10, 2021 00:59
…thub.com/project-chip/connectedhomeip into feature/device_attestation_complete
…thub.com/project-chip/connectedhomeip into feature/DA-constructors
Changing naming convention for constants simpler logic for context tags. Eliminate boolean array indexed by tag and have boolean flags. Removed vector for VendorReserved data and changed signature of helper functions.
…thub.com/project-chip/connectedhomeip into feature/device_attestation_complete
include generated zap files. coauthor -- clang format
mleisner
force-pushed
the
feature/device_attestation_complete
branch
from
0e9dcf8 to
adb5725
Compare
added 12 commits
September 13, 2021 22:07
…thub.com/project-chip/connectedhomeip into feature/DA-constructors
use TLV::ContiguousBufferTLVReader have consecutive context tags add TODOs for future work improve documentations on usage in headers Have seperate tests for deconstruction with/without firmware info.
…thub.com/project-chip/connectedhomeip into feature/DA-constructors
…rrors. Use UINT32_MAX instead of -1.
…thub.com/project-chip/connectedhomeip into feature/device_attestation_complete
Rerun zap.
…thub.com/project-chip/connectedhomeip into feature/DA-constructors
clang-format did a number of reformats Updated firmwareInfoTestVector
…thub.com/project-chip/connectedhomeip into feature/DA-constructors
Set Device AttestationVerifier Example during DeviceCommissioner Initialization. rename sendOperationalCertsImmediately flag to sendCertificateChainImmediately. Added nonce parameter to SendAttestationRequestCommand method. Added method to handle Attestation Information Validation result. Added state of Device Attestation to Commissioner State Machine. Moved CertificateType enum to DeviceAttestationVerifier module. Added missing comments on newly introduced methods. rename keyid to sessionid.
mleisner
force-pushed
the
feature/device_attestation_complete
branch
2 times, most recently
from
37e6c24 to
0655e3f
Compare
added 2 commits
September 20, 2021 17:14
…-comcast:mleisner/connectedhomeip into feature/complete-redux
changed error code to be more conforming Added TODO comments in constructor PR project-chip#9544
mleisner
force-pushed
the
feature/device_attestation_complete
branch
from
0655e3f to
b3e4d24
Compare
added 4 commits
September 20, 2021 19:51
added missing attestation commands to rest of examples. regenerated zap files
added 16 commits
September 22, 2021 07:45
…-comcast:mleisner/connectedhomeip into feature/device_attestation_complete
… rest of code to comply with latest changes. added more TODOs. Added Error and Progress Logs to Attestation Flow in CHIPDeviceController.
…-comcast:mleisner/connectedhomeip into feature/device_attestation_complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Working device attestation
Change overview
(includes two files
src/credentials/DeviceAttestationConstructor.cpp
src/credentials/DeviceAttestationConstructor.h
that was in PR project-chip#9544)
Testing
Tested Commissioning using chip-tool and lighting apps