Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #97

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Small fixes #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5973183
Make a barely working version of coffee that uses NewHelm.
wpietri Feb 13, 2024
0f043aa
install newhelm and everything else from our repository
dhosterman Feb 13, 2024
9a3ca5f
Tidy the code, find some constants that get a successful run.
wpietri Feb 14, 2024
3c1f198
Got the tests working.
wpietri Feb 14, 2024
2a53d14
Delete old helm test data.
wpietri Feb 14, 2024
d058b74
Remove a bunch of the oldhelm stuff.
wpietri Feb 14, 2024
36d0cbd
Code cleanup.
wpietri Feb 15, 2024
b504bfd
Remove SUT that's not working. Fix filename. Assorted other cleanup.
wpietri Feb 15, 2024
ec7ffdd
Remove SUT that's not working. Fix filename. Assorted other cleanup.
wpietri Feb 15, 2024
3bb1086
Not sure how this ever worked before, but explicitly telling pytest t…
wpietri Feb 15, 2024
f7bb1f0
Improve class name, fix spelling mistakes.
wpietri Feb 15, 2024
3a98a83
Merge remote-tracking branch 'origin/main' into coffee-uses-newhelm
wpietri Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coffee/newhelm_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@


@dataclasses.dataclass
class NewSutDescription:
class SutDescription:
key: str
display_name: str

def __hash__(self):
return super().__hash__()


class NewhelmSut(NewSutDescription, Enum):
class NewhelmSut(SutDescription, Enum):
GPT2 = "gpt2", "OpenAI GPT-2"
LLAMA_2_7B = "llama-2-7b", "Meta Llama 2, 7b parameters"
4 changes: 2 additions & 2 deletions tests/make_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def run_tests_for_harm_on_sut(harm, sut, max_instances):
#
# Recreates the test data for the things that use newhelm results loaded from disk.
#
# You shouldn't normally need to run this. If you do, perhaps because of a strucutral change
# That makes it impossible to laod the data, make sure all the related tests are consistent.
# You shouldn't normally need to run this. If you do, perhaps because of a structural change
# That makes it impossible to load the data, make sure all the related tests are consistent.
#

load_plugins()
Expand Down
Loading