Coffee uses newhelm #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
brianwgoldman
approved these changes
Feb 15, 2024
mkly
reviewed
Feb 15, 2024
|
|
||
|
|
||
| @dataclasses.dataclass | ||
| class NewSutDescription: |
There was a problem hiding this comment.
Did we maybe mean for this to be NewhelmSutDescription?
There was a problem hiding this comment.
No, but I should change it to just SutDescription now that the old SutDescription has been removed.
| # | ||
| # Recreates the test data for the things that use newhelm results loaded from disk. | ||
| # | ||
| # You shouldn't normally need to run this. If you do, perhaps because of a strucutral change |
There was a problem hiding this comment.
So minor but: strucutural structural
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does basically the same thing as before, but using NewHelm instead of Helm. Note that NewHelm is much more fragile, so you may have to try any given run a number of times to get it to work, but it does work for me on occasion. Note also that the --web-only option doesn't work for the moment, as we'll have to discuss whether coffee should just save scores or whether it's better to pull things out of the newhelm run data.