Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify locale handling by using lowercase strings everywhere #768

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rogthefrog
Copy link
Contributor

The current locale implementation uses an enum, which is handy for validation, but it isn't used consistently throughout the code. Some functions declare a locale argument of the Locale type, but in actuality sometimes they get plain strings, so the function code has to 1) check the type 2) validate whether the string is a valid locale. The Locale object itself is just a bag of strings.

@bkorycki, @bollacker and I discussed simplifying and using strings instead.

@rogthefrog rogthefrog requested a review from a team as a code owner December 20, 2024 23:11
Copy link

github-actions bot commented Dec 20, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant