simplify locale handling by using lowercase strings everywhere #768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current locale implementation uses an enum, which is handy for validation, but it isn't used consistently throughout the code. Some functions declare a locale argument of the Locale type, but in actuality sometimes they get plain strings, so the function code has to 1) check the type 2) validate whether the string is a valid locale. The Locale object itself is just a bag of strings.
@bkorycki, @bollacker and I discussed simplifying and using strings instead.