Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update huggingface sdk to solve date parsing issue #725

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

rogthefrog
Copy link
Contributor

Merging should wait until the gold modelbench image is built.

huggingface/huggingface_hub#2671

@rogthefrog rogthefrog requested a review from a team as a code owner December 2, 2024 18:34
Copy link

github-actions bot commented Dec 2, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@wpietri
Copy link
Contributor

wpietri commented Dec 3, 2024

Why shouldn't this be included in the 1.0 release?

@rogthefrog
Copy link
Contributor Author

@wpietri it can be if you'd like. I haven't tested the changes beyond the unit tests. The main branch before this change is a known good quantity, so that's what I'd normally use for a release. But it's up to you!

@rogthefrog rogthefrog temporarily deployed to Scheduled Testing December 3, 2024 20:22 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing December 3, 2024 20:22 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing December 3, 2024 20:22 — with GitHub Actions Inactive
@wpietri wpietri merged commit b366ae3 into main Dec 3, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants