-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix smoke tests #718
Merged
Merged
Fix smoke tests #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
had a problem deploying
to
Scheduled Testing
November 26, 2024 19:52 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 26, 2024 20:51 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 26, 2024 22:37 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 26, 2024 22:49 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 26, 2024 23:44 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 26, 2024 23:49 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 27, 2024 00:01 — with
GitHub Actions
Failure
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 01:28 — with
GitHub Actions
Inactive
…f you're not asked to preserve some of those secrets
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 02:11 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 02:15 — with
GitHub Actions
Inactive
rogthefrog
had a problem deploying
to
Scheduled Testing
November 27, 2024 02:59 — with
GitHub Actions
Failure
rogthefrog
had a problem deploying
to
Scheduled Testing
November 27, 2024 03:14 — with
GitHub Actions
Failure
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:17 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:23 — with
GitHub Actions
Inactive
…the test step. This isn't the prettiest way to do it, but using reusable workflows with outputs doesn't work because secret-containing outputs get scrubbed by Github.
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:37 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:37 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:37 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:39 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:54 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:54 — with
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
November 27, 2024 03:54 — with
GitHub Actions
Inactive
rogthefrog
requested review from
wpietri,
bollacker,
dhosterman and
bkorycki
November 27, 2024 04:00
wpietri
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wins
Fails
I tried to extract the credential/secret logic into a dependent workflow so it could be shared between the app test and smoke test workflows. That didn't work because:
So I just C&P'ed the secrets section into a second workflow, like a neanderthal.