Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic journal documentation #672

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

wpietri
Copy link
Contributor

@wpietri wpietri commented Nov 8, 2024

No feedback on the journal docs, so I guess we'll merge this and then add to it later.

@wpietri wpietri requested a review from a team as a code owner November 8, 2024 16:03
Copy link

github-actions bot commented Nov 8, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks good to me! It's been helpful in writing the consistency checker, so I think it serves its purpose well.

@wpietri wpietri merged commit ce0f033 into main Nov 8, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@wpietri wpietri deleted the add-some-journal-docs branch November 8, 2024 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants