More ops fixes #664
Merged
More ops fixes #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
dhosterman
approved these changes
Nov 4, 2024
| @@ -485,7 +552,9 @@ def _check_ready_to_run(self): | |||
|
|
|||
| def run(self) -> BenchmarkRun: | |||
| self._check_ready_to_run() | |||
There was a problem hiding this comment.
Do you want to collect the RuntimeErrors from both annotators and suts here so that all issues can be addressed simultaneously? If I'm understanding correctly, right now, it won't check the annotators if there's an issue with the suts.
There was a problem hiding this comment.
I was thinking to keep them separate, as right now our annotators can take up to 15 minutes to decide whether or not they're ready. This will get people quick notification of a SUT problem. But if we can get off HuggingFace to something faster, then that would make sense to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a little more journaling.
Make sure our external resources are live before starting a massive run.