Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke test improvements #617

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Smoke test improvements #617

merged 2 commits into from
Oct 21, 2024

Conversation

wpietri
Copy link
Contributor

@wpietri wpietri commented Oct 20, 2024

  • stop creating issues, as we don't look at them
  • reenable the benchmark runs as part of the test

@wpietri
Removing automatic issue creation, as we don't look at them and I'm t…
72cf56e 
…ired of getting the emails.

Reenabling actual benchmark running as part of smoke test.
@wpietri
format fix
daa7993
@wpietri wpietri requested a review from a team as a code owner October 20, 2024 14:02
@github-actions GitHub Actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

dhosterman
dhosterman approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@dhosterman dhosterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wpietri wpietri merged commit 7278e9a into main Oct 21, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
@wpietri wpietri deleted the smoke-test-doesnt-create-issues branch November 4, 2024 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhosterman dhosterman dhosterman approved these changes

@rogthefrog rogthefrog rogthefrog approved these changes

@bkorycki bkorycki Awaiting requested review from bkorycki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpietri @rogthefrog @dhosterman