Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In process helm runner 2 #58

Merged
merged 5 commits into from
Feb 2, 2024
Merged

In process helm runner 2 #58

merged 5 commits into from
Feb 2, 2024

Conversation

dhosterman
Copy link
Collaborator

Unconnected in process Helm runner ready to be ripped out. Also, renaming the coffee.helm module to coffee.helm_runner so it doesn't clobber the helm library in the namespace.

…ary in the namespace; add helm_interface which includes an InProcessHelmRunner
@dhosterman dhosterman requested review from wpietri and mkly February 1, 2024 23:37
@dhosterman dhosterman self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely looks fit for purpose. Thanks for doing this.

@dhosterman dhosterman merged commit 2c4e01d into main Feb 2, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
@dhosterman dhosterman deleted the in-process-helm-runner-2 branch February 5, 2024 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants