Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadows to elements #49

Merged

Conversation

mkly
Copy link
Member

@mkly mkly commented Jan 30, 2024

This is a bit difficult to see, but the comp does provide a very slight drop shadow on some of the elements. I feel like this is important as it does add a subtle focus to the white of the highlighted elements

image

@mkly mkly requested a review from a team as a code owner January 30, 2024 23:30
@mkly mkly requested review from dhosterman and removed request for a team January 30, 2024 23:30
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Collaborator

@dhosterman dhosterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@dhosterman dhosterman merged commit 9a0a373 into benchmark-has-harms Jan 31, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@mkly mkly deleted the mkly/benchmark-has-harms-12-box-shadow branch February 2, 2024 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants