Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark has harms #53

Merged
merged 22 commits into from
Jan 31, 2024
Merged

Benchmark has harms #53

merged 22 commits into from
Jan 31, 2024

Conversation

dhosterman
Copy link
Collaborator

No description provided.

wpietri and others added 22 commits January 24, 2024 11:57
  * BenchmarkDefinition - abstract notion of a given benchmark
  * BenchmarkScore - the result of applying a benchmark to a SUT; has stars
  * HarmDefinition - abstract notion of a sub-score for a benchmark
  * HarmScore - the result of applying a harm's set of tests to a SUT; has stars

  Thanks to pairing with Daniel, the UI works as before, without harms expressed in the interface. More to come.
* Add spacing for tables

* Fix test error for import
…gn' into benchmark-has-harms

# Conflicts:
#	src/coffee/templates/benchmark.html
* Fix debug regression

* Add shadows to elements
…nce. Note: a few mypy errors remain and will be fixed with the in-process Helm runner
@dhosterman dhosterman requested review from wpietri and mkly January 31, 2024 20:11
@dhosterman dhosterman self-assigned this Jan 31, 2024
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the python looks solid and familiar to me. The HTML seems good as best I can tell!

Copy link
Member

@mkly mkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkly
Copy link
Member

mkly commented Jan 31, 2024

@dhosterman I'll defer to you for merging this as you might want to squash the commit into and and adjust the message etc.

@dhosterman dhosterman merged commit 6776971 into main Jan 31, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@wpietri wpietri deleted the benchmark-has-harms branch March 4, 2024 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants