-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark has harms #53
Conversation
* BenchmarkDefinition - abstract notion of a given benchmark * BenchmarkScore - the result of applying a benchmark to a SUT; has stars * HarmDefinition - abstract notion of a sub-score for a benchmark * HarmScore - the result of applying a harm's set of tests to a SUT; has stars Thanks to pairing with Daniel, the UI works as before, without harms expressed in the interface. More to come.
… R O V I S I O N A L
… aggregate the normalized scores.
* Add spacing for tables * Fix test error for import
…ons' into benchmark-has-harms
…gn' into benchmark-has-harms # Conflicts: # src/coffee/templates/benchmark.html
* Fix debug regression * Add shadows to elements
…nce. Note: a few mypy errors remain and will be fixed with the in-process Helm runner
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the python looks solid and familiar to me. The HTML seems good as best I can tell!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@dhosterman I'll defer to you for merging this as you might want to squash the commit into and and adjust the message etc. |
No description provided.