Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up formatting checks #146

Merged
merged 23 commits into from
Nov 24, 2021
Merged

Set up formatting checks #146

merged 23 commits into from
Nov 24, 2021

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented Nov 23, 2021

Closes #136
Closes #128

Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 23, 2021

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@d-uzlov d-uzlov marked this pull request as draft November 23, 2021 05:39
Signed-off-by: Danil Uzlov <[email protected]>
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov d-uzlov marked this pull request as ready for review November 23, 2021 08:36
@d-uzlov d-uzlov requested a review from anhappdev November 23, 2021 08:36
@anhappdev
Copy link
Collaborator

Is something wrong with your git? Many files are touched, but the content is not changed. It has no effect on the code but make review more difficult, and also tracking the history of the files.

@anhappdev
Copy link
Collaborator

Ok. Now I see. Those files are formatted with new line endings. For this kind of change (same change on multiple files), please create it in a separate PR next time. That make it easier to review changes.

@d-uzlov
Copy link
Contributor Author

d-uzlov commented Nov 23, 2021

Ok. Now I see. Those files are formatted with new line endings. For this kind of change (same change on multiple files), please create it in a separate PR next time. That make it easier to review changes.

Ok. Sorry for the inconvenience.

@d-uzlov d-uzlov merged commit c7c35f2 into master Nov 24, 2021
@d-uzlov d-uzlov deleted the 136/ci-format-check branch November 24, 2021 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up formatting checks using GitHub CI Use Unix line endings
2 participants