Web UI profiles #618
Open
Web UI profiles #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cli/medperf/commands/list.py # cli/medperf/entities/benchmark.py # cli/medperf/entities/cube.py # cli/medperf/entities/dataset.py # cli/medperf/entities/interface.py
Right now all settings are distributed among hardcoded (and updated during init) values at `config.py`, and dynamic (loaded from .yaml file) profile's `ConfigManager`. So there is a confusion - which module is responsible for what. In future I'm going to move all dynamic values to `ConfigManager`, ensuring `settings` is just a hardcoded list of default init values and is never rewritten.
# Conflicts: # cli/medperf/entities/benchmark.py # cli/medperf/entities/cube.py
VukW
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @router.get("/fetch-yaml") | ||
| async def fetch_yaml(url: str): | ||
| try: | ||
| response = requests.get(url) |
Check failure
Code scanning / CodeQL
Full server-side request forgery Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #606, and #615
Web-UI: add a profile drop-down field to change profiles quickly