[SD][v4.0] RCPs to use num of samples instead iterations #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
ahmadki
force-pushed
the
ahmadki/sd_iters_to_samples
branch
3 times, most recently
from
1957232 to
6328dfc
Compare
ahmadki
changed the title
hiwotadese
previously approved these changes
Feb 22, 2024
ahmadki
changed the title
|
@hiwotadese |
ahmadki
force-pushed
the
ahmadki/sd_iters_to_samples
branch
from
6328dfc to
1e848cf
Compare
ahmadki
changed the title
| @@ -178,6 +178,7 @@ | |||
| FIRST_EPOCH_NUM = "first_epoch_num" | |||
| STATUS = "status" | |||
| STEP_NUM = "step_num" | |||
| SAMPLES_COUNT = "samples_count" | |||
There was a problem hiding this comment.
Wouldn't SAMPLES_NUM be more consistent with EPOCH_NUM and STEP_NUM? I know it's probably more accurate to call it COUNT. Not sure what matters more
|
Hi @nv-rborkar , can we merge this? |
hiwotadese
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address #351
Another PR to update the benchmark code will be opened in the training repo