use the default sut folder name supplied if cm-sut-json is not there #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Nov 13, 2024
| @@ -18,7 +18,7 @@ def preprocess(i): | |||
|
|
|||
| hw_name = env['CM_HW_NAME'] | |||
|
|
|||
| backend = env.get('CM_MLPERF_BACKEND', '') | |||
| backend = env.get('CM_MLPERF_BACKEND', 'pytorch') # default is set to pytorch | |||
There was a problem hiding this comment.
We should not set the default backend here. It should only be for submission generation step if backend information is not available elsewhere.
There was a problem hiding this comment.
Hi @arjunsuresh , updated in commit cf30e25
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in reference to issue: #536