Added docker detatched option #477
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
| @@ -34,6 +35,7 @@ jobs: | |||
| python-version: "3.8" | |||
| include: | |||
| - os: windows-latest | |||
| docker: "" | |||
There was a problem hiding this comment.
cant we install docker on windows non interactively?
There was a problem hiding this comment.
@arjunsuresh , there is command line installation method for windows in official docker website. Mybe with some workaround its possible?
There was a problem hiding this comment.
It works but only for Windows docker images which CM does not support currently.
| attempt=1 | ||
| docker --version | ||
| docker info | ||
| while ! docker --version > /dev/null 2>&1; do |
There was a problem hiding this comment.
Hi @arjunsuresh , I think we are able to successfully obtain the output of docker --version even though docker daemon is not running, just docker needs to be installed.
| - name: Start Docker Daemon on macos | ||
| if: runner.os == 'macOS-deactivated' | ||
| run: | | ||
| open /Applications/Docker.app |
There was a problem hiding this comment.
When the docker application starts up for the first time, it asks for accepting the aggreements then only proceeds to starting the docker daemon. Maybe we have to find some better way?
No description provided.