Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #455: Copy local repo to docker instead of git clone #467

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Oseltamivir
Copy link
Contributor

@Oseltamivir Oseltamivir commented Nov 3, 2024

resolves #455

Uses CM_REPO_PATH to set local repo to copy to CM/repos/mlcommons@cm4mlops

This PR performs just the basic functionality.

  • currently DOES NOT USE docker_cm_repo. I am not sure if we must use docker_cm_repo
  • tested with cm docker script --tags=detect,os --env.CM_REPO_PATH=/Users/user/Downloads/cm4mlops
  • copies to CM/repos/mlcommons@cm4mlops. Will need to change this

uses CM_REPO_PATH to set local repo to copy to CM/repos/mlcommons@cm4mlops, currently DOES NOT USE docker_cm_repo
@Oseltamivir Oseltamivir requested a review from a team as a code owner November 3, 2024 18:48
Copy link

github-actions bot commented Nov 3, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@Oseltamivir Oseltamivir changed the title Implements #455 Implements #455: Copy local repo to docker instead of git clone Nov 4, 2024
@arjunsuresh
Copy link
Contributor

Thank you @Oseltamivir for the PR. It looks good. Lets discuss it during tomorrow meeting.

@Oseltamivir
Copy link
Contributor Author

Thank you @Oseltamivir for the PR. It looks good. Lets discuss it during tomorrow meeting.

Sure, is the link the same: https://meet.google.com/jtf-crbz-ezz ?

@arjunsuresh
Copy link
Contributor

Yes, its the same. See you tomorrow.

CM Framework task force
Tuesday, November 5 · 7:05 – 7:30pm
Time zone: Europe/London
Google Meet joining info
Video call link: https://meet.google.com/jtf-crbz-ezz
Or dial: ‪(GB) +44 20 3873 3170‬ PIN: ‪214 853 005 6654‬#
More phone numbers: https://tel.meet/jtf-crbz-ezz?pin=2148530056654

Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change. It is quite useful.

@arjunsuresh arjunsuresh merged commit aa878d1 into mlcommons:main Nov 6, 2024
44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@Oseltamivir Oseltamivir deleted the feature/local_CM_PATH branch November 9, 2024 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to use host CM_REPO as docker_cm_repo
2 participants