Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent-child relationship issue in text2chakra_converter.py #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

venkataramaraoguttikonda

Problem:

There was an AttributeError when attempting to add a parent node to a child node in text2chakra_converter.py. The issue occurred because the Node message in et_def.proto does not have a parent field.

Solution:

The fix involves using the existing ctrl_deps field to maintain parent-child relationships. Specifically, I modified the add_parent function to append the parent node's ID to the ctrl_deps field of the child node.

TaekyungHeo and others added 2 commits February 22, 2024 20:03
Previously, the data_deps field was utilized to encode operator
dependencies in simulations. However, data_deps should actually
be reserved for encoding data dependencies, not for simulating
operator dependencies. Therefore, this commit updates the code
to ensure that pytorch2chakra_converter.py employs ctrl_deps for
this purpose.
@venkataramaraoguttikonda venkataramaraoguttikonda requested a review from a team as a code owner September 15, 2024 16:49
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
1 out of 2 committers have signed the MLCommons CLA.
@TaekyungHeo
@venkataramaraoguttikonda
venkataramaraoguttikonda seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@srinivas212
Copy link
Contributor

@venkataramaraoguttikonda thanks for the PR. you need to sign the CLA before we can proceed. Can you try the following:

@srinivas212
Copy link
Contributor

srinivas212 commented Oct 5, 2024

Thanks for your PR. You need to sign the CLA before we can proceed. Can you try the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants