Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tuning rules to exclude test set from scoring procedure #528

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

fsschneider
Copy link
Contributor

As discussed in the WG meetings, this PR updates the rules to use "Option C", i.e. removing the test set from the scoring procedure and instead only using the validation set.

The test targets are still defined for each workload and will be used for additional analysis of the results but they are not relevant for scoring/ranking submissions.

Merge after #476

@fsschneider fsschneider requested a review from georgedahl October 3, 2023 12:28
@fsschneider fsschneider requested a review from a team as a code owner October 3, 2023 12:28
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the base branch from main to dev October 12, 2023 19:40
priyakasimbeg
priyakasimbeg previously approved these changes Nov 3, 2023
@fsschneider fsschneider dismissed priyakasimbeg’s stale review November 3, 2023 16:47

The merge-base changed after approval.

georgedahl
georgedahl previously approved these changes Nov 6, 2023
Copy link
Contributor

@georgedahl georgedahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these things need to change, but maybe we should just merge this PR and do another after it? For example, just merge this and then make it clear the submission process information is just documentation?

@fsschneider fsschneider dismissed georgedahl’s stale review November 6, 2023 03:02

The merge-base changed after approval.

georgedahl
georgedahl previously approved these changes Nov 6, 2023
@fsschneider fsschneider dismissed georgedahl’s stale review November 6, 2023 09:58

The merge-base changed after approval.

@priyakasimbeg priyakasimbeg self-requested a review November 6, 2023 21:55
@priyakasimbeg priyakasimbeg merged commit 77c86c2 into mlcommons:dev Nov 6, 2023
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
@fsschneider fsschneider deleted the UpdateTuningRules branch November 13, 2023 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants