Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added output path for optimize model #896

Merged

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Jul 9, 2024

Fixes #895

Proposed Changes

  • added a separate cli parameter
  • internal logic updated to handle new parameter

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@scap3yvt scap3yvt requested a review from a team as a code owner July 9, 2024 17:44
Copy link
Contributor

github-actions bot commented Jul 9, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati mentioned this pull request Jul 9, 2024
10 tasks
Copy link
Contributor

@VukW VukW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scap3yvt
Copy link
Collaborator Author

scap3yvt commented Jul 10, 2024

Let's add a new param to entrypoint tests also?

https://github.com/mlcommons/GaNDLF/blob/new-apis_v0.1.0-dev_optmize-model_with_output/testing/entrypoints/test_optimize_model.py

Thanks for the reminder! Added in 7deb9b4

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (2c61453) to head (79be7b6).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           new-apis_v0.1.0-dev     #896      +/-   ##
=======================================================
+ Coverage                94.44%   94.46%   +0.02%     
=======================================================
  Files                      159      159              
  Lines                     9391     9395       +4     
=======================================================
+ Hits                      8869     8875       +6     
+ Misses                     522      520       -2     
Flag Coverage Δ
unittests 94.46% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati merged commit f125e2d into new-apis_v0.1.0-dev Jul 13, 2024
25 checks passed
@sarthakpati sarthakpati deleted the new-apis_v0.1.0-dev_optmize-model_with_output branch July 13, 2024 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants