-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding function to get augmentation transforms #889
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Please change the base to https://github.com/mlcommons/GaNDLF/tree/new-apis_v0.1.0-dev |
Done, not sure if we should re-run the tests somehow |
Hi! Folks, by some strange reason this PR didn't trigger CI tests at all. However, it brought a bug (failing test) inside base branch, that failed in a neighbor PR: https://github.com/mlcommons/GaNDLF/actions/runs/9724955407/job/26841721449?pr=890 I'm not sure if it's the only failure. @szmazurek can you plz run the tests locally to check if everything behaves as you expected in the PR? |
@VukW on it! |
@szmazurek are you looking into the error? Starting to see this pop up for other PRs as well. |
+, all tests are running successfully now. Merged the fix together with #890 . |
Hey guys, I had a chance to look at that closely just now, but I see @VukW already fixed that - thanks! |
Fixes #888
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].