Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoding pip version for workflows #887

Conversation

benmalef
Copy link
Contributor

Brief description

This PR tries to fix the following error with the new version of pip(24.1.1). Latest pip (24.1, released on 06/20/2024) does not install omegaconf==2.1.0 due to non-standard metadata:

DEPRECATION: omegaconf 2.1.0 has a non-standard dependency specifier PyYAML>=5.1.*. pip 24.1 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of omegaconf or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063

logging error

Solution

In this thread is the solution.
It is proposed to update the pip version in the files.

Proposed Changes

Temporarily, I have updated files to use pip 24.0 until this is fixed.
The following are modified:

  • Docker files: Dockerfile-CPU, Dockerfile-CUDA11.8,Dockerfile-CUDA12.1,RCOm
  • Workflow files: mlcube-test, openfl-test, python-test

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@benmalef benmalef changed the title Change pip version to 24.0. Change pip version to 24.0 Jun 27, 2024
@benmalef
Copy link
Contributor Author

Hi @sarthakpati, please review the PR.

@benmalef benmalef marked this pull request as ready for review June 27, 2024 16:38
@benmalef benmalef requested a review from a team as a code owner June 27, 2024 16:38
@sarthakpati sarthakpati changed the title Change pip version to 24.0 Hardcoding pip version Jun 27, 2024
@sarthakpati sarthakpati changed the title Hardcoding pip version Hardcoding pip version for workflows Jun 27, 2024
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Geeks-Sid Geeks-Sid merged commit 12ac1b4 into mlcommons:new-apis_v0.1.0-dev Jun 27, 2024
20 of 22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@benmalef benmalef deleted the change_pip_version_in_workflows branch July 17, 2024 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants