Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warnings with MSVC #307

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix Warnings with MSVC #307

merged 1 commit into from
Jan 16, 2024

Conversation

junrushao
Copy link
Member

No description provided.

@junrushao junrushao force-pushed the bugfix/2024-01-15/win-warning branch from 52ebfd8 to df5e3ff Compare January 16, 2024 04:20
@junrushao junrushao changed the title Fix Windows Warnings Fix Warnings on MSVC and NVCC Jan 16, 2024
@junrushao junrushao mentioned this pull request Jan 16, 2024
Merged
@junrushao junrushao force-pushed the bugfix/2024-01-15/win-warning branch from df5e3ff to 33e7965 Compare January 16, 2024 04:42
@junrushao junrushao changed the title Fix Warnings on MSVC and NVCC Fix Warnings with MSVC Jan 16, 2024
@junrushao junrushao merged commit 5212d14 into mlc-ai:mlc Jan 16, 2024
2 of 3 checks passed
junrushao added a commit that referenced this pull request Jan 16, 2024
@junrushao
Fix Warnings with MSVC (#307)
afda68c
junrushao added a commit that referenced this pull request Jan 17, 2024
@junrushao
Fix Warnings with MSVC (#307)
5c83214
junrushao pushed a commit that referenced this pull request Jan 17, 2024
@LeshengJin @junrushao
BUGFIX - To Be Upstreamed
7073e26 
[Bugfix] fix win pipe.h (#306)
[ROCm] Some fixes of ROCm codegen
Fix Warnings with MSVC (#307)
Fix NVCC Warnings (#308)
[Vulkan] Some fixes of Vulkan codegen (#309)
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@LeshengJin @junrushao
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
6c7c7a5 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)
junrushao added a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
7471cd1 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
@junrushao junrushao mentioned this pull request Jan 17, 2024
Merged
junrushao added a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
9cb8e28 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
9c8cf08 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
a7818f0 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
tqchen pushed a commit to apache/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan (#16414)
cbe9c14 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (#16404,
  #16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit that referenced this pull request Jan 21, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan (#16414)
62dfa27 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@junrushao