[CMake] Add CMAKE_CUDA_ARCHITECTURES to CMakeLists.txt #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
approved these changes
Jan 1, 2024
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 1, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 1, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
junrushao
reviewed
Jan 2, 2024
| @@ -531,6 +531,15 @@ else() | |||
| set(CMAKE_CUDA_STANDARD 17) | |||
| endif() | |||
|
|
|||
| if ((USE_CUDA AND USE_CUTLASS)) | |||
| if(NOT DEFINED CMAKE_CUDA_ARCHITECTURES) | |||
| set(CMAKE_CUDA_ARCHITECTURES "75;80;86;89;90") | |||
There was a problem hiding this comment.
likely we will have to remove 75 and add 87 in this list
There was a problem hiding this comment.
A better way is to avoid setting CMAKE_CUDA_ARCHITECTURES in cmake file, which might contaminate other downstream projects, but instead configure it in CD:
There was a problem hiding this comment.
Also we need to turn on USE_FLASHINFER in the CD pipelines
There was a problem hiding this comment.
I tweaked this PR and moved the logic to CUDA.cmake with NVCC version detection. Though it's still part of cmake files. 30c129e
junrushao
pushed a commit
that referenced
this pull request
Jan 2, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 6, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 6, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 6, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 7, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 10, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 10, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 11, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 12, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
junrushao
pushed a commit
that referenced
this pull request
Jan 16, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
junrushao
pushed a commit
that referenced
this pull request
Jan 17, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
junrushao
pushed a commit
that referenced
this pull request
Jan 17, 2024
1. Bump `3rdparty/cutlass_fpA_intB_gemm` 2. Set `CMAKE_CUDA_ARCHITECTURES=75;80;86;89;90` when it's not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rdparty/cutlass_fpA_intB_gemmCMAKE_CUDA_ARCHITECTURES=75;80;86;89;90when it's not defined