Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add date picker to stats and standings screens and other QOL updates #41

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

AxBolduc
Copy link

  • Have both teams' box scores shown in the box score pane
  • Add HR to box score
  • Show stats (team/player, hitting/pitching) as of date selected
  • Show standings as of date selected

@andschneider
Copy link
Collaborator

Hey @AxBolduc, thanks for the PR, this looks awesome! Could you do a few Cargo things to start:

  • run cargo fmt and use its formatting
  • run cargo clippy --all-targets --workspace --all-features and fix all warnings and errors
  • run cargo test --all-targets --workspace --all-features and make sure everything passes

These should get CI to pass

@andschneider andschneider self-requested a review February 26, 2024 05:56
api/src/client.rs Show resolved Hide resolved
src/components/debug.rs Outdated Show resolved Hide resolved
src/ui/help.rs Show resolved Hide resolved
@AxBolduc
Copy link
Author

Hey @andschneider any chance we can get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants