Plutus exporter #14
Closed
Plutus exporter #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrocze
reviewed
Apr 3, 2023
| peRole :: !ScriptRole, | ||
| peVersion :: !ScriptVersion, | ||
| peDescription :: !Text, | ||
| peScript :: !(Some CompiledCode) |
There was a problem hiding this comment.
Can we omit GADTs in some way?
zmrocze
reviewed
Apr 3, 2023
| instance HasScriptHash TypedScriptEnvelope where | ||
| scriptHashOf TypedScriptEnvelope{..} = scriptHash (Script tsScript) | ||
|
|
||
| instance HasScriptHash PlutusEnvelope where |
There was a problem hiding this comment.
We really shouldn't hardcode both the hashing algorithm and the byte prefixes. Isn't there some instance calculating e2e hash? Only in cardano-api?
|
This is an attempt at making a script exporter that would work with both PlutusTx and Plutarch, but avoiding the dependency on The attempt is successful in that, but introduces a lot of hardcoded hashing/encoding details, that really should never be a part of scaffold. So no plan to merge it in its current form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12
Everything is implemented, but needs testing