Merkle Memberships Program; Clean up #2
Conversation
chfanghr
changed the title
chfanghr
force-pushed
the
connor/simple-password-tree-root-update
branch
from
ddb8b08
to
f34c12f
Compare
chfanghr
force-pushed
the
connor/simple-password-tree-root-update
branch
from
f34c12f
to
2afdd64
Compare
adamczykm
force-pushed
the
connor/simple-password-tree-root-update
branch
4 times, most recently
from
b2319f6
to
accb962
Compare
adamczykm
force-pushed
the
connor/simple-password-tree-root-update
branch
from
accb962
to
230514e
Compare
|
Additionally, I think that we will need to rethink the IProver interface. Good that we don't use it anywhere yet. |
chfanghr
force-pushed
the
connor/simple-password-tree-root-update
branch
from
0c810c5
to
4fdf63b
Compare
There was a problem hiding this comment.
It's a nice functional implementation but got noisy. Typescript syntax is not very beautiful it appears. I'll propose some changes.
src/plugins/merkleMemberships/common/merkleMembershipsProgram.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
There are some changes required.
Please try to add some docstrings already. They don't have to be beautiful yet, but should explain the high-level operations of the code. To make it easier to understand how the proof is achieved etc.
Additionaly, we need the headless client to be able to test the flow of the updated plugin.
It can be done with another PR though.
chfanghr
changed the title
| )(proof); | ||
| } | ||
|
|
||
| async fetchPublicInputs( |
There was a problem hiding this comment.
The problem here is that asking for a specific index of the tree reveals the identity.
The only solution is to transfer the entire tree. Then it should be searched for the index and this way the witness could be generated.
If there's no easy way to serialize the tree then the list of all leaves should be send and the tree should be rebuilt.
There was a problem hiding this comment.
This is apparently not very efficient. I don't see why this hurts anonymity - a client can always make a bunch of junk requests to confuse the server if the server decides to log the traffic.
Aside from that, I have some concerns regarding the security of this implementation - if someone knows the value x where Is this possible? Not so familiar with the poseidon hash algorithm.Poseidon.hash([x]) == Field(0) and if any of the trees have one or more holes, we are screwed.
No description provided.