Add image retrieval from FAISS index #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @mrchtr!
Would be ideal if we let the user search with embeddings or images as well. Similar to the retrieve_laion_by_embedding component. That should be possible now in a single component with the additionalFields support, although maybe not really nice yet without schema support.
We can do it in a separate PR anyway.
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
|
Also, we probably want to use a GPU, I did it here for the embedding component: |
src/fondant/components/retrieve_images_from_faiss_index/fondant_component.yaml
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/fondant_component.yaml
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/tests/resources/create_dummy_dataset.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/tests/test_component.py
Outdated
Show resolved
Hide resolved
mrchtr
commented
Mar 5, 2024
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index/src/main.py
Outdated
Show resolved
Hide resolved
src/fondant/components/retrieve_images_from_faiss_index_by_prompt/src/main.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component expects a dataset in the form of:
The component will load the dataset from the remote storage into the component, initialise a CLIP model,
and retrieve similar images based on given prompts.