Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu extra with dask-cuda and bump minimum Python version to 3.9 #862

Merged
merged 8 commits into from
Feb 20, 2024

Conversation

RobbeSneyders
Copy link
Member

Separately resolving dask-cuda in our components leads to dependency conflicts. Since we put a lot of focus on ML components, I think it makes sense to add it as an extra.

It only supports Python 3.9+ though, so we need to drop Python 3.8, which will be end of life later this year.

Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have still to change this:

MIN_PYTHON_VERSION = (3, 8)
MAX_PYTHON_VERSION = (3, 11)

in the lightweight_component.py

@RobbeSneyders
Copy link
Member Author

Good catch. We have Python versions in a lot of places 😅

Base automatically changed from feature/component-setup to main February 20, 2024 08:44
@RobbeSneyders RobbeSneyders merged commit 4a18696 into main Feb 20, 2024
10 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/dask-cuda branch February 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants