Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component dir in build script #856

Merged
merged 1 commit into from
Feb 16, 2024
+3 −3
Merged

Update component dir in build script #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/build_components.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function usage {

# Parse the arguments
while [[ "$#" -gt 0 ]]; do case $1 in
-r |--registry) registry="$2"; shift;;
-rg|--registry) registry="$2"; shift;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is -r still used somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. It was duplicate before, since it's used for --repo as well.

-n |--namespace) namespace="$2"; shift;;
-d |--components-dir ) components_dir="$2"; shift;;
-r |--repo) repo="$2"; shift;;
Expand All @@ -40,7 +40,7 @@ fi

# Set default values for optional arguments if not passed
component="${components:-all}"
components_dir="${components_dir:-components}"
components_dir="${components_dir:-src/fondant/components}"
namespace="${namespace:-fndnt}"
repo="${repo:-ml6team/fondant}"

Expand Down Expand Up @@ -107,7 +107,7 @@ for dir in "${components_to_build[@]}"; do
echo "Freezing Fondant dependency version to ${tags[0]}"
docker build --push "${args[@]}" \
--build-arg="FONDANT_VERSION=${tags[0]}" \
--label org.opencontainers.image.source=https://github.com/${repo}/components/{BASENAME} \
--label org.opencontainers.image.source=https://github.com/${repo}/src/fondant/components/{BASENAME} \
.

docker pushrm ${full_image_name} | echo "
Expand Down
Loading