Move cloud auth to sdk #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
requested review from
GeorgesLorre,
RobbeSneyders and
mrchtr
mrchtr
reviewed
Jan 15, 2024
src/fondant/cli.py
Outdated
| @@ -218,6 +202,9 @@ def start_explore(args): | |||
| tag=args.tag, | |||
| port=args.port, | |||
| extra_volumes=extra_volumes, | |||
| auth_gcp=args.auth_gcp, | |||
There was a problem hiding this comment.
What do you think about combining these arguments into a single one, for instance auth_provider=AZURE,AWS,GCP? Might be easier to update the different auth options without changing the interface.
There was a problem hiding this comment.
good suggestion! Implemented
mrchtr
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments that enabled authenticating to different clouds through volume mounting credentials were restricted to the CLI and were not explicitly available in the SDK.
This PR that moves the argument for authenticating to one of the clouds in the DockerRunner for the CLI to the SDK
e.g
authenticating to gcp