Add component argument inference #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
mrchtr,
GeorgesLorre and
PhilippeMoussalli
|
Pipeline failure is unrelated. Submitted #764 to fix it. |
PhilippeMoussalli
approved these changes
Jan 9, 2024
GeorgesLorre
approved these changes
Jan 9, 2024
| BUILTIN_TYPES = [str, int, float, bool, dict, list] | ||
|
|
||
|
|
||
| def annotation_to_type(annotation: t.Any) -> t.Type: |
This was referenced Jan 16, 2024
RobbeSneyders
added a commit
that referenced
this pull request
Jan 18, 2024
Follow-up to use the argument inference functionality added in #763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751
This PR introduces functionality to infer the arguments from a
Componentclass. The result is a dictionary with the argument names as keys, andArgumentinstances as values, which is the format ofcomponent_spec.args.We can leverage this behavior for Lightweight Python components as described in #750.
Did some TDD here, let me know if I missed any cases.