-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move integration test into examples #756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrchtr!
As discussed, we need to check each step in the propagation chain of the exit codes:
|
I've updated the code.
I've updated the test script. The sample pipeline is located in Beside that in the folder is a I've adopted the ci/cd script. Now it scans the example folders and looks for This allows us to add more integration test samples to the example folder in the future. |
I think we are still missing this |
c774827
to
555a7a8
Compare
A bit of back and forth. In the meanwhile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I missed your comment about it not being needed before, my mistake. Looks good now.
folder
For now I've used a bash script for the execution. If we want to add more integration test we should think about a different approach.
Fixes #727