Add logs to weaviate #734
Merged
Add logs to weaviate #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
approved these changes
Dec 20, 2023
| df = part.compute() | ||
| for row in df.itertuples(): | ||
| for row in tqdm(df.itertuples(), desc="Processing rows", total=len(df)): |
There was a problem hiding this comment.
Have you tested this?
Providing progress on the row level might be a bit much. I guess partitions would be enough?
There was a problem hiding this comment.
Yeah indeed this just adds in another bar but the process time per partition is generally not that long, removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logs to give indication on indexing progress