Move to modules instead of classes for home page and common interface #717
Conversation
| @@ -1,12 +1,9 @@ | |||
| """General configuration for the app.""" | |||
|
|
|||
| SESSION_STATE_VARIABLES = [ | |||
There was a problem hiding this comment.
We should aim to get rid of these completely.
This is currently used to initialize all session state variables at the start of the application, to prevent errors when accessing non-initialized values. But this brings us in broken states anyway. We should make sure the flow is set up so values are only accessed after initialization, or non-initialization is handled in the accessing code.
There was a problem hiding this comment.
This file was split into common.py and sidebar.py
There was a problem hiding this comment.
This is a fix for an issue raised by @Hakimovich99, where you cannot switch pipelines because the run selection would error.
| dask.config.set({"dataframe.convert-string": False}) | ||
|
|
||
|
|
||
| class PipelineOverviewApp(MainInterface): |
There was a problem hiding this comment.
Extra logs since the docker compose logs don't show on Windows for Jan.
There was a problem hiding this comment.
Thanks @RobbeSneyders! (I'm approving it but I've never deep dived in the explorer code, meaning I barely understand the changes. So my approval isn't that useful haha)
This PR simplifies the data explorer implementation a bit by moving the home page and common interfaces into modules instead of a long hierarchy of classes with a singleton class at the top.
I think we should do the same for the dataset views, but that would increase the size of the PR, so I suggest to do it later in a separate one.