Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sagemaker script generator #712

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Fix/sagemaker script generator #712

merged 3 commits into from
Dec 11, 2023

Conversation

GeorgesLorre
Copy link
Collaborator

Hopefully fixed by:

https://docs.python.org/3/library/shlex.html#shlex.quote

Still need to test on aws

@RobbeSneyders
Copy link
Member

Thanks @GeorgesLorre!

Maybe we should add bash -n scriptname to the test to validate the generated script?

@GeorgesLorre
Copy link
Collaborator Author

Maybe we should add bash -n scriptname to the test to validate the generated script?

It does call fondant execute ... so not sure what the easiest way is to call this in the test

@RobbeSneyders
Copy link
Member

bash -n just checks the script, it doesn't execute it.

@RobbeSneyders RobbeSneyders merged commit 38163c9 into main Dec 11, 2023
6 checks passed
@RobbeSneyders RobbeSneyders deleted the fix/sagemaker-script-generator branch December 11, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgesLorre @RobbeSneyders